-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOP-2854: Allow to override CreationDate #65
base: main
Are you sure you want to change the base?
Conversation
I am out of the office until 04-01-2021.
Please contact InfoSuite support at [email protected] for assistance.
Note: This is an automated response to your message "[apache/xmlgraphics-fop] FOP-2854: Allow to override CreationDate (#65)" sent on 23-12-2020 13:59:37.
This is the only notification you will receive while this person is away.
|
Hi, I would still like to see this reviewed/tested/merged |
This repository seems to be a mirror of the original SVN repository only. So it is unlikely that PRs are accepted here. You can find more information onhow to contribute on the development page: https://xmlgraphics.apache.org/fop/dev/ |
I am out of the office until 13-12-2021.
Please contact InfoSuite support at ***@***.*** for assistance.
Note: This is an automated response to your message "Re: [apache/xmlgraphics-fop] FOP-2854: Allow to override CreationDate (#65)"( sent on 10-12-2021 20:58:56) .
This is the only notification you will receive while this person is away.
|
Thanks @Simulant87 - I now filed https://issues.apache.org/jira/browse/FOP-3040 |
I am out of the office until 13-12-2021.
Please contact InfoSuite support at ***@***.*** for assistance.
Note: This is an automated response to your message "Re: [apache/xmlgraphics-fop] FOP-2854: Allow to override CreationDate (#65)"( sent on 11-12-2021 07:37:33) .
This is the only notification you will receive while this person is away.
|
Allow to override build date with SOURCE_DATE_EPOCH in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This patch was done while working on reproducible builds for openSUSE.
@infosuitemka hi! are you back in the office? |
I have opened a similar PR at #87, which IMO is a bit cleaner. |
@simonsteiner1984 is this something you could help with reviewing? (a pull request #87 is open to resolve this) |
Apologies; I misunderstood this to be an issue thread, with a pull request available to resolve it. Now I understand that both are pull requests, so two options are available. I don't have any personal preference between the two. |
You can use the fop api to override dates, bug is set to wont fix |
Not all parts of fop respect the overridden date. |
We wouldnt use env variables, for passing params to fop |
Normally we set xmp data from fo file |
Maybe can be done via https://xmlgraphics.apache.org/fop/2.10/metadata.html |
The xmp data itself yes, but the xmp data timestamp is always the current date. |
As @t-8ch notes, although many metadata timestamps can be specified at document build-time, My interest in this bug stems from investigating reproducibility of PDF documentation for Debian's |
Allow to override build date with
SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This patch was done while working on reproducible builds for openSUSE.
Note: probably only a partial fix towards reproducible pdf output / https://issues.apache.org/jira/browse/FOP-2854