Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOP-2854: Allow to override CreationDate #65

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bmwiedemann
Copy link

@bmwiedemann bmwiedemann commented Dec 23, 2020

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This patch was done while working on reproducible builds for openSUSE.

Note: probably only a partial fix towards reproducible pdf output / https://issues.apache.org/jira/browse/FOP-2854

@infosuitemka
Copy link

infosuitemka commented Dec 23, 2020 via email

@bmwiedemann
Copy link
Author

Hi, I would still like to see this reviewed/tested/merged
Anything I can help?

@Simulant87
Copy link

This repository seems to be a mirror of the original SVN repository only. So it is unlikely that PRs are accepted here. You can find more information onhow to contribute on the development page: https://xmlgraphics.apache.org/fop/dev/

@infosuitemka
Copy link

infosuitemka commented Dec 10, 2021 via email

@bmwiedemann
Copy link
Author

Thanks @Simulant87 - I now filed https://issues.apache.org/jira/browse/FOP-3040

@infosuitemka
Copy link

infosuitemka commented Dec 11, 2021 via email

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This patch was done while working on reproducible builds for openSUSE.
@kpcyrd
Copy link

kpcyrd commented Jan 22, 2025

@infosuitemka hi! are you back in the office?

@t-8ch
Copy link

t-8ch commented Jan 24, 2025

I have opened a similar PR at #87, which IMO is a bit cleaner.

@jayaddison
Copy link

@simonsteiner1984 is this something you could help with reviewing? (a pull request #87 is open to resolve this)

@jayaddison
Copy link

@simonsteiner1984 is this something you could help with reviewing? (a pull request #87 is open to resolve this)

Apologies; I misunderstood this to be an issue thread, with a pull request available to resolve it. Now I understand that both are pull requests, so two options are available. I don't have any personal preference between the two.

@simonsteiner1984
Copy link
Contributor

You can use the fop api to override dates, bug is set to wont fix

@t-8ch
Copy link

t-8ch commented Mar 1, 2025

You can use the fop api to override dates, bug is set to wont fix

Not all parts of fop respect the overridden date.

@simonsteiner1984
Copy link
Contributor

We wouldnt use env variables, for passing params to fop

@simonsteiner1984
Copy link
Contributor

Normally we set xmp data from fo file

@simonsteiner1984
Copy link
Contributor

Maybe can be done via https://xmlgraphics.apache.org/fop/2.10/metadata.html

@t-8ch
Copy link

t-8ch commented Mar 1, 2025

Normally we set xmp data from fo file

The xmp data itself yes, but the xmp data timestamp is always the current date.
(Same for the file ID). See the first two commits of #87 .

@jayaddison
Copy link

As @t-8ch notes, although many metadata timestamps can be specified at document build-time, xmp:CreateDate is currently an exception to that.

My interest in this bug stems from investigating reproducibility of PDF documentation for Debian's pam package - the only source of variance in recent builds appears to be the xmp:CreateDate in the included PDF files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants