[TIR][FIX] update FlopEstimator to include missing nodes #17598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrongtest-intellif
requested changes
Jan 21, 2025
src/tir/analysis/estimate_flops.cc
Outdated
| @@ -138,6 +138,7 @@ class FlopEstimator : private ExprFunctor<TResult(const PrimExpr& n)>, | |||
| } | |||
|
|
|||
| TResult VisitExpr_(const BufferLoadNode* op) override { return TResult(); } | |||
| TResult VisitStmt_(const AttrStmtNode* op) override { return TResult(); } | |||
There was a problem hiding this comment.
Do we need VisitStmt(op->body) for attr annotation since there maybe valid mops under attr body?
There was a problem hiding this comment.
I was a bit unsure about this when I added the node. My original thought was that the attribute node would only serve to hold values for downstream passes such as codegen and would not be converted to executable code and therefore should not be in the flops estimate.
I updated the visitor to visit the body and value of AttrStmtNode, however I can undo this if it is not correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FlopEstimator to include missing nodes that would otherwise cause tuning to fail for certain TIR functions