[Disco] Allow allocation that only exists on worker0 #16993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `disco.Session.scatter_from_worker0` function expects a `DRef` which an `NDArray` on worker 0, and `NullOpt` on all other workers. Prior to this commit, there was no method in the `disco.Session` that could be used to make such a `DRef`. As a result, every use of `scatter_from_worker0` generated an error, stating that non-zero workers should have `NullOpt` as their `send` argument. This commit adds a `worker0_only: bool` argument to `disco.Session.empty`. This can be used to generate an allocation that only exists on worker zero, suitable for use in `scatter_from_worker0`.
masahi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
disco.Session.scatter_from_worker0function expects aDRefwhich anNDArrayon worker 0, andNullOpton all other workers. Prior to this commit, there was no method in thedisco.Sessionthat could be used to make such aDRef. As a result, every use ofscatter_from_worker0generated an error, stating that non-zero workers should haveNullOptas theirsendargument.This commit adds a
worker0_only: boolargument todisco.Session.empty. This can be used to generate an allocation that only exists on worker zero, suitable for use inscatter_from_worker0.