[CI] Enable unittests for disco #16975
Open
+26
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor of the unittest folder in apache#16110 did not include the `tests/python/disco` folder in the list of folders to run in CI.
yongwww
approved these changes
May 14, 2024
|
Looks like there's some failing tests, which seem to have crept in while the tests were disabled.
|
- Remove `R.func_attr({"global_symbol": "main"}`, as it is now
implicitly generated. Explicitly specifying the global symbol is
legal, but is ill-formed if it differs from the name used by the
`GlobalVar`.
- Replace the import of `tvm.testing.disco` with
`tvm.exec.disco_worker`, since the file has been moved.
- Use `tvm.testing.requires_nccl` and `tvm.testing.requires_rccl` as
part of the parametrization over CCL types. This will skip the test
when run in environments that do not have the specified CCL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor of the unittest folder in #16110 did not include the
tests/python/discofolder in the list of folders to run in CI.