TINKERPOP-3070 Cannot run console if working directory contains spaces #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #3012 +/- ##
=============================================
+ Coverage 76.14% 76.36% +0.21%
- Complexity 13152 13235 +83
=============================================
Files 1084 1061 -23
Lines 65160 61582 -3578
Branches 7285 7344 +59
=============================================
- Hits 49616 47027 -2589
+ Misses 12839 12035 -804
+ Partials 2705 2520 -185 ☔ View full report in Codecov by Sentry. |
|
VOTE +1, pending CHANGELOG entry. |
|
Thanks for tracking down that fix @flora-jin, VOTE +1 (pending CHANGELOG entry) |
flora-jin
changed the title
|
VOTE +1 |
flora-jin
force-pushed
the
TINKERPOP-3070
branch
from
d9bdca3 to
bef4e2b
Compare
kenhuuu
reviewed
Feb 5, 2025
Co-authored-by: kenhuuu <[email protected]>
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3070
If the current working directory contains spaces, gremlin.sh does not handle it properly when launching the console, and the JVM will search for an incorrect main class and fail.
For example if I simply rename the standard console distribution directory to
foo bar:foo bar/ $ bin/gremlin.sh
Error: Could not find or load main class bar
Caused by: java.lang.ClassNotFoundException: bar
Added quotations around directory path in order to ensure spaces in directory name are not considered two separate strings