Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINKERPOP-3038: Console plugins file can't accept empty lines #3003

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

flora-jin
Copy link
Contributor

TINKERPOP: https://issues.apache.org/jira/browse/TINKERPOP-3038

Added if statement in console.groovy to check for invalid plugins in plugins.txt (outputs invalid plugin and incorrect plugin name on console)
Added check to skip empty lines in plugins.txt on Mediator.groovy.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.36%. Comparing base (9b46b67) to head (260b018).
Report is 307 commits behind head on 3.7-dev.

Files with missing lines Patch % Lines
...rg/apache/tinkerpop/gremlin/console/Console.groovy 0.00% 6 Missing ⚠️
...g/apache/tinkerpop/gremlin/console/Mediator.groovy 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             3.7-dev    #3003      +/-   ##
=============================================
+ Coverage      76.14%   76.36%   +0.22%     
- Complexity     13152    13236      +84     
=============================================
  Files           1084     1061      -23     
  Lines          65160    61582    -3578     
  Branches        7285     7344      +59     
=============================================
- Hits           49616    47028    -2588     
+ Misses         12839    12036     -803     
+ Partials        2705     2518     -187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cole-Greer
Copy link
Contributor

Thanks for the bugfix @flora-jin. VOTE +1

@andreachild
Copy link
Contributor

VOTE +1

@flora-jin flora-jin closed this Jan 31, 2025
@flora-jin flora-jin deleted the tinkerpop-3038-3.7 branch January 31, 2025 23:02
@flora-jin flora-jin restored the tinkerpop-3038-3.7 branch January 31, 2025 23:11
@flora-jin flora-jin reopened this Jan 31, 2025
@xiazcy
Copy link
Contributor

xiazcy commented Feb 3, 2025

Thanks for the bug fix! VOTE +1

@kenhuuu
Copy link
Contributor

kenhuuu commented Feb 4, 2025

VOTE +1, pending CHANGELOG entry.

@flora-jin flora-jin changed the title Console plugins file can't accept empty lines TINKERPOP-3038: Console plugins file can't accept empty lines Feb 4, 2025
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@kenhuuu kenhuuu merged commit a439f81 into apache:3.7-dev Feb 8, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants