-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TINKERPOP-3038: Console plugins file can't accept empty lines #3003
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #3003 +/- ##
=============================================
+ Coverage 76.14% 76.36% +0.22%
- Complexity 13152 13236 +84
=============================================
Files 1084 1061 -23
Lines 65160 61582 -3578
Branches 7285 7344 +59
=============================================
- Hits 49616 47028 -2588
+ Misses 12839 12036 -803
+ Partials 2705 2518 -187 ☔ View full report in Codecov by Sentry. |
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Mediator.groovy
Outdated
Show resolved
Hide resolved
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
Outdated
Show resolved
Hide resolved
Thanks for the bugfix @flora-jin. VOTE +1 |
618d8b9
to
ffdb0cf
Compare
VOTE +1 |
Thanks for the bug fix! VOTE +1 |
VOTE +1, pending CHANGELOG entry. |
baa015b
to
c69747b
Compare
19ceeb9
to
5a581db
Compare
Co-authored-by: kenhuuu <[email protected]>
TINKERPOP: https://issues.apache.org/jira/browse/TINKERPOP-3038
Added if statement in console.groovy to check for invalid plugins in plugins.txt (outputs invalid plugin and incorrect plugin name on console)
Added check to skip empty lines in plugins.txt on Mediator.groovy.