feat(feature flag): Setting TAGGING_SYSTEM to True by default

[rusackas]

SUMMARY

Following on the heels of #32317, and a discussion with @eschutho, we feel that this feature is ready for promotion to being on by default, whether this makes it into 5.0 or a subsequent minor. Again tagging @kgabryje @michael-s-molina @mistercrunch in case there are any concerns here preventing this change.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset/config.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[mistercrunch]

Yup!

[rusackas]

Whoa... CI is not happy. Not sure yet what can of worms I've opened here :/

[mistercrunch]

Wondering who's the best person to help, though should be a simple glitch around feature flags handling in tests/builds(?)

[sadpandajoe]

Shouldn't we mention this in UPDATING.md to let people know it's on by default now?

[mistercrunch]

Shouldn't we mention this in UPDATING.md to let people know it's on by default now?

I agree that feature flag default changes aren't breaking changes, but should be noted in UPDATING.md, where more heads up to the person performing the release is better. It allows them to know about the change in behavior, and prevent it if they decide so.

[github-actions]

@sadpandajoe Processing your ephemeral environment request here. Action: up.

[sadpandajoe]

@rusackas I pushed up a possible fix for the e2e cypress test that's failing. When tags are turned on, we add a Tags column between Status and Owners, so the e2e was failing since it was expecting Owners but it was returning Tags

[github-actions]

@sadpandajoe Ephemeral environment spinning up at http://52.13.110.49:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.