fix(dashboard): unable to drop tabs in columns #28242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
requested review from
rusackas,
betodealmeida,
eschutho and
michael-s-molina
michael-s-molina
approved these changes
Apr 29, 2024
michael-s-molina
added
the
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 44690fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It fixes the addressed issue #28025.
The tabs cannot be placed in columns due to the invalid depth level assigned to the siblings of the columns.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--drop-tabs-in-columns.mov
After:
after--drop-tabs-in-columns.mov
TESTING INSTRUCTIONS
Create a new dashboard and then drop a column
Drop tabs to the column
ADDITIONAL INFORMATION