Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Webpack dev-server build warning): Create false value alias for moment-with-locales #28229

Merged

Conversation

rtexelm
Copy link
Contributor

@rtexelm rtexelm commented Apr 26, 2024

SUMMARY

This is a workaround to suppress the ./locale build warning when using the webpack dev-server involving a well documented (more reports) bug in the now defunct moment library. This is meant to remove the warning, anticipating a migration away from moment in the future.

Example warning

WARNING in ./node_modules/moment/min/moment-with-locales.js 2159:16-50
Module not found: Error: Can't resolve './locale' in 'superset-frontend/node_modules/moment/min'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rtexelm rtexelm changed the title fix(Webpack dev-server moment warning): Create false value alias for moment-with-locales fix(Webpack dev-server build warning): Create false value alias for moment-with-locales Apr 26, 2024
@rtexelm rtexelm marked this pull request as ready for review April 26, 2024 05:58
@john-bodley john-bodley merged commit 4d2247a into apache:master Apr 29, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants