Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dev-Server): Edit ChartPropsConfig reexport to be a type object #28225

Merged

Conversation

rtexelm
Copy link
Contributor

@rtexelm rtexelm commented Apr 25, 2024

SUMMARY

This should solve the warning that ChartPropsConfig does not exist in superset-ui-core/src/chart/models/ChartProps
See here and here

Example of warning fixed:

WARNING in ./packages/superset-ui-core/src/chart/index.ts 24:0-28
export 'ChartPropsConfig' (reexported as 'ChartPropsConfig') was not found in './models/ChartProps' (possible exports: default)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rtexelm rtexelm marked this pull request as ready for review April 25, 2024 21:53
@geido geido merged commit 2e5f3ed into apache:master Apr 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants