fix(contextmenu): uncaught TypeError #28203
Open
+65
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR resolves a uncaught TypeError in MixedTimeseries charts with saved metrics.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
Screencast from 04-24-2024 05:16:25 PM.webm
After
Screencast from 04-24-2024 08:09:58 PM.webm
TESTING INSTRUCTIONS
Create a MixedTimeseries chart with using saved metrics. Without the PR, the context menu (right click) will throw an uncaught TypeError exception. With the PR, the context menu works as expected.
ADDITIONAL INFORMATION