Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to the ui-core #28187

Merged
merged 4 commits into from Apr 30, 2024
Merged

chore(superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to the ui-core #28187

merged 4 commits into from Apr 30, 2024

Conversation

rtexelm
Copy link
Contributor

@rtexelm rtexelm commented Apr 23, 2024 •
edited

SUMMARY

In trying to convert this test to RTL it became necessary to add the capability of using RTL inside the package thus adding dependencies.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rtexelm rtexelm changed the title chore(superset-ui-core and NoResultsComponent):Migrate to RTL, add RTL configuration to the ui-core package chore (superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL configuration to the ui-core package Apr 23, 2024
@rtexelm rtexelm force-pushed the chore/to-rtl-packages-superset-ui-core-test-chart/sc-79110 branch from c2025bb to e7e6ec1 Compare April 25, 2024 01:26
@rtexelm rtexelm changed the title chore (superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL configuration to the ui-core package chore (superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to ui-core Apr 25, 2024
@rtexelm rtexelm changed the title chore (superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to ui-core chore (superset-ui-core and NoResultsComponent): Migrate to RTL Apr 25, 2024
@rtexelm rtexelm changed the title chore (superset-ui-core and NoResultsComponent): Migrate to RTL chore (superset-ui-core and NoResultsComponent): Migrate to RTL and add modules Apr 25, 2024
@rtexelm rtexelm changed the title chore (superset-ui-core and NoResultsComponent): Migrate to RTL and add modules chore (superset-ui-core/NoResultsComponent): Migrate test to RTL and add modules Apr 25, 2024
@rtexelm rtexelm changed the title chore (superset-ui-core/NoResultsComponent): Migrate test to RTL and add modules chore (superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to the ui-core Apr 25, 2024
@rtexelm rtexelm changed the title chore (superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to the ui-core chore(superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to the ui-core Apr 25, 2024
@rtexelm rtexelm marked this pull request as ready for review April 25, 2024 02:01
@geido geido merged commit 601896b into apache:master Apr 30, 2024
53 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilykuang lilykuang lilykuang approved these changes

@geido geido geido approved these changes

@justinpark justinpark Awaiting requested review from justinpark

Assignees
No one assigned
Labels
dependencies:npm packages size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtexelm @lilykuang @geido