Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a11y): enable ECharts aria-label #28171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frassinier
Copy link
Contributor

@frassinier frassinier commented Apr 22, 2024

SUMMARY

Increasing accessibility support in Apache/Superset through enhanced a11y features, such as generating aria-label with Echarts, is crucial for ensuring inclusivity and usability for all users, including those with disabilities.

By adhering to WCAG guidelines and making adjustments to colors and patterns as required, we not only enhance the user experience for individuals with disabilities but also align with standards for accessibility, promoting a more inclusive and equitable platform for all users.

        aria: {
          enabled: true,
          decal: {
            show: true,
          },
        },

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@frassinier frassinier changed the title feat(a11y): enable aria description for echarts feat(a11y): enable ECharts aria-label Apr 22, 2024
@frassinier frassinier changed the title feat(a11y): enable ECharts aria-label feat(a11y): enable Echarts aria-label Apr 22, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Apr 22, 2024
@john-bodley john-bodley changed the title feat(a11y): enable Echarts aria-label feat(a11y): enable ECharts aria-label Apr 22, 2024
@rusackas
Copy link
Member

I'm not sure we want to turn on the patterns by default. A lot of people don't want/need them, and this provides no option to disable them. We could, of course, add a chart control, but I don't think that's much better. I think the right approach might be to wait until we have this SIP in effect, so a user can choose to apply this across the board for charts/dashboards they view/edit/create.

@frassinier
Copy link
Contributor Author

frassinier commented Apr 22, 2024

@rusackas, I agree! but what do you think of just adding the automated aria-label, maybe under a feature flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins review:checkpoint Last PR reviewed during the daily review standup size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants