[SPARK-54450][INFRA] Allow run-tests to accept unittest style string for test names #53157
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Nov 23, 2025
| return python_execs | ||
|
|
||
|
|
||
| def split_and_validate_testnames(testnames): |
Member
There was a problem hiding this comment.
This is nice. Can we show the full example of this, and fix the docs in https://spark.apache.org/docs/latest/api/python/development/testing.html#testing-pyspark as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow
run-teststo take unittest style string liketest_module.TestClass.test_case, in addition totest_module TestClass.test_case.Also some extra check is added for the existence of the test module - we are not sending it to
bin/pysparkif we can't find the module.Why are the changes needed?
It's extra work to split the string when copy/paste directly from unittest output (CI failures for example).
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually confirmed the
.connection works and the original way is not impacted (except that we have some new checks for the module).Was this patch authored or co-authored using generative AI tooling?
No.