[SPARK-53355][PYTHON][SQL] fix numpy 1.x repr in type tests #52247
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrobby
force-pushed
the
SPARK-53355-fix-numpy-repr
branch
from
7f4de1d to
e813915
Compare
xinrong-meng
reviewed
Sep 5, 2025
python/pyspark/sql/tests/udf_type_tests/test_udf_input_types.py
Outdated
Show resolved
Hide resolved
xinrong-meng
approved these changes
Sep 5, 2025
xinrong-meng
reviewed
Sep 5, 2025
| return tuple(convert_to_numpy_printable(elem) for elem in x) | ||
| elif isinstance(x, dict): | ||
| return {k: convert_to_numpy_printable(v) for k, v in x.items()} | ||
| elif hasattr(x, "dtype") and hasattr(x, "item"): |
There was a problem hiding this comment.
This will capture numpy array. Are we targeting at scalars only isinstance(x, np.generic)?
There was a problem hiding this comment.
good point, added an isinstance(x, np.generic)
There was a problem hiding this comment.
np.generic is the base class for all numpy scalar types, why do we still need to check hasattr(x, "dtype") and hasattr(x, "item")?
xinrong-meng
reviewed
Sep 5, 2025
python/pyspark/sql/tests/udf_type_tests/test_udf_input_types.py
Outdated
Show resolved
Hide resolved
xinrong-meng
approved these changes
Sep 5, 2025
benrobby
changed the title
|
@xinrong-meng this is ready from my side. Is there a way to trigger the master tests with the different envs on this PR? I have run this locally, but it would be nice to confirm additionally in CI. |
HyukjinKwon
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
__repr__differentlyWhy are the changes needed?
Build / Python-only (master, Minimum dependencies of PySpark)Does this PR introduce any user-facing change?
No
How was this patch tested?
ran tests locally with numpy 1.22.4
Was this patch authored or co-authored using generative AI tooling?
No