[SPARK-52156][SQL] Put legacy CREATE TEMPORARY TABLE ... USING provider under the flag #50902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
May 15, 2025
| @@ -361,6 +361,11 @@ class SparkSqlAstBuilder extends AstBuilder { | |||
| invalidStatement("CREATE TEMPORARY TABLE IF NOT EXISTS", ctx) | |||
| } | |||
|
|
|||
| if (ctx.tableProvider != null | |||
| && conf.getConf(SQLConf.BLOCK_CREATE_TEMP_TABLE_WITH_PROVIDER)) { | |||
| throw invalidStatement("CREATE TEMPORARY TABLE ... USING", ctx) | |||
There was a problem hiding this comment.
shall have customize the error message to say that they can do CREATE TEMP VIEW ... USING instead?
There was a problem hiding this comment.
Should we just move the check under the logWarning which is already there or create separate error?
cloud-fan
approved these changes
May 15, 2025
pan3793
reviewed
May 16, 2025
| @@ -250,6 +250,13 @@ object SQLConf { | |||
| .booleanConf | |||
| .createWithDefault(true) | |||
|
|
|||
| val BLOCK_CREATE_TEMP_TABLE_USING_PROVIDER = | |||
| buildConf("spark.sql.blockCreateTempTableUsingProvider") | |||
There was a problem hiding this comment.
should the conf under spark.sql.legacy. namespace? e.g. spark.sql.legacy.allowCreateTempTableUsingProvider, and don't forget the .version("4.1.0") though it's an internal conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Blocking legacy feature of CREATE TEMPORARY TABLE ... USING under the flag. The default keeps it enabled.
Why are the changes needed?
CREATE TEMPORARY TABLE ... USING provider uses legacy path which creates views with LogicalPlan for storage instead of sqlText. This could pose a problem for systems that rely on sqlText being present and we want to provide users with the option to disable it.
Does this PR introduce any user-facing change?
No, just a guard for a legacy feature.
How was this patch tested?
Test added to the relevant suite.
Was this patch authored or co-authored using generative AI tooling?
No.