[SPARK-43046][FOLLOWUP][SS][CONNECT] Remove not used line in deduplicateWithinWatermark #46345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zhengruifeng Hi Ruifeng, I believe this line was added just to align with the behavior of this commit, 92847d9. But I think we don't have a |
HyukjinKwon
approved these changes
May 3, 2024
|
Merged to master. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…ateWithinWatermark ### What changes were proposed in this pull request? An extra assignment was added when we first introduce `dropDuplicatesWithinWatermark` in apache@4d76511. We don't need this line. ### Why are the changes needed? Code cleanup ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing CI ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46345 from WweiL/deduplicate-within-wm-connect. Authored-by: Wei Liu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
An extra assignment was added when we first introduce
dropDuplicatesWithinWatermarkin 4d76511. We don't need this line.Why are the changes needed?
Code cleanup
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing CI
Was this patch authored or co-authored using generative AI tooling?
No