Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17655: Remove ExternalFileField #3244

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Mar 6, 2025

https://issues.apache.org/jira/browse/SOLR-17655

Description

ExternalFileField is deprecated, remove it.

Solution

Remove deprecated Field Type.

Tests

Existing tests

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@github-actions github-actions bot added documentation Improvements or additions to documentation tests cat:search cat:index cat:schema labels Mar 6, 2025
@epugh
Copy link
Contributor Author

epugh commented Mar 11, 2025

Going to merge later this week barring any feedback!

@gerlowskija
Copy link
Contributor

ExternalFileField is deprecated, remove it.

Is it? SOLR-17655 looks like it was created to put that deprecation in place, but it's not there yet afaict.

(That's not to say that we can't remove it on 'main' in anticipation of deprecating it in an eventual 9.9. I'm not saying we shouldn't remove it necessarily - just making sure we don't have wires crossed on what's deprecated at the moment.)

@epugh
Copy link
Contributor Author

epugh commented Mar 11, 2025

Doh, you are right: https://solr.apache.org/guide/solr/latest/indexing-guide/field-types-included-with-solr.html#deprecated-field-types doesn't actually list ExternalFileField!!!!!!!!!!!!!

If I make a seperate PR to go on branch_9x that updates the Ref Guide and adds the @Deprecated tags, does that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants