SOLR-17648: multiThreaded=true: changed queue implementation #3155
+10
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from unlimited to 1000 max, after which the caller thread will execute. Didn't need the RejectedExecutionException avoidance hack anymore; Lucene 9.12 has it.
sigram
reviewed
Feb 3, 2025
| } | ||
| }, | ||
| new LinkedBlockingQueue<>( | ||
| EnvUtils.getPropertyAsInteger("solr.searcherCollector.queueSize", 1000)), |
There was a problem hiding this comment.
IMO we don't need to document obscure settings (I think this is). If you think it should be documented, let me know where it should be. If this queue size is exceeded, the outcome is still a working system but the performance will be somewhat less than what it otherwise would be. FWIW 1000 feels about right to me. I reviewed the code in Lucene 9.12 that cleverly uses the parent thread.
I plan to change this property to be "solr.search.multiThreaded.queueSize" so as to have a category after solr. -- see https://cwiki.apache.org/confluence/display/SOLR/System+property+naming+structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from unlimited to 1000 max, after which the caller thread will execute.
Didn't need the RejectedExecutionException avoidance hack anymore; Lucene 9.12 has it.
https://issues.apache.org/jira/browse/SOLR-17648