SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager #3154
+35
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nager Co-authored-by: Chris Hostetter <[email protected]>
dsmiley
approved these changes
Jan 31, 2025
|
This fails every time on Crave, because a grade test runner is returning an exit code of "1". This doesn't replicate for me, but it is suspicious given that |
|
Nvm, replicated it locally. |
|
Aha! Tracked it down to |
epugh
approved these changes
Feb 4, 2025
| ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| PrintStream stdoutSim = new PrintStream(baos, true, StandardCharsets.UTF_8.name()); | ||
| StatusTool tool = new StatusTool(stdoutSim); | ||
| try { | ||
| System.setProperty("basicauth", "harry:HarryIsUberCool"); |
There was a problem hiding this comment.
any chance that this pattern shows up anywhere else and or is suggested in docs? Magic system variable?
|
|
||
| assertParsedDate( | ||
| inputString, | ||
| Date.from(Instant.ofEpochMilli(expectTs)), | ||
| "parse-date-patterns-default-config"); | ||
|
|
||
| // A bug in Java 9 (not in 8) causes this to fail! (not fixed yet?!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17379