Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Github Actions runtime and cleanup always #3152

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

uvatbc
Copy link
Contributor

@uvatbc uvatbc commented Jan 31, 2025

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

The Solr tests ran for over 2 days - and I forgot to check them over the weekend.
Keeping a 96 core machine running for that long is expensive.

Solution

  1. Limit the runtime to 90 minutes
  2. At the end, always send a clear kill signal to the job running in Crave

Tests

None: This is a Github Actions change

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

1. Limit the runtime to 90 minutes
2. At the end, always send a clear kill signal to the job running in Crave
@HoustonPutman
Copy link
Contributor

I changed it to 40 min, because if everything is working it runs in like 20 min.

@dsmiley dsmiley merged commit e81bc32 into apache:main Jan 31, 2025
1 check passed
@dsmiley
Copy link
Contributor

dsmiley commented Jan 31, 2025

Thanks!

@uvatbc uvatbc deleted the ga-timeout branch January 31, 2025 20:31
dsmiley pushed a commit that referenced this pull request Feb 5, 2025
* Limit Github Actions runtime and cleanup always

1. Limit the runtime to 40 minutes
2. At the end, always send a clear kill signal to the job running in Crave

---------

Co-authored-by: Houston Putman <[email protected]>
(cherry picked from commit e81bc32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants