SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Patch looks good. |
|
Just curious; I suppose this bug might show as an NPE? |
It doesnt show at all. The thread thats running the async request fails, and since its not in the catch, it doesnt pass the exception to the completion step. So the thread just goes away without logging anything. Took a while to pin it down because of this. |
risdenk
approved these changes
Jan 30, 2025
anshumg
approved these changes
Jan 30, 2025
|
Nice catch! thanks! |
gus-asf
approved these changes
Jan 30, 2025
HoustonPutman
added a commit
that referenced
this pull request
Jan 30, 2025
This bug causes async requests to be uncompleted in some error scenarios. The HttpShardHandler can hang indefinitely when this happens. (cherry picked from commit db0cbd3)
HoustonPutman
added a commit
that referenced
this pull request
Jan 30, 2025
This bug causes async requests to be uncompleted in some error scenarios. The HttpShardHandler can hang indefinitely when this happens. (cherry picked from commit db0cbd3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17637