Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated KnnVectorField use #3121

Merged
merged 31 commits into from
Feb 3, 2025
Merged

remove deprecated KnnVectorField use #3121

merged 31 commits into from
Feb 3, 2025
+10 −10

Conversation

cpoerschke
Copy link
Contributor

Split out from the Lucene 10.x upgrade #3053 PR.

The class was marked experimental in/until Lucene 9.4 and in Lucene 9.5 became deprecated:

So the removal here can go to both main and branch_9x branches with no JIRA or solr/CHANGES.txt entry needed in my opinion.

Ishan Chattopadhyaya and others added 30 commits January 13, 2025 11:13
WIP: Upgrading to Lucene 10
c22cfaa
@noblepaul
Removed dependency on TimeLimitingCollector
822d562
@noblepaul
Removed the deprecated methods
c29bdeb
@noblepaul
Removed dependency on deprecated TopDocCollector
8c9e9ed
Moved setRewriteMethod() to constructor, replaced scorer() with score…
f4b8b16 
…rSupplier()
Replaced some more scorer() with scorerSupplier()
38a22d4
Changed rewrite method signature, added DV skip to FieldInfo construc…
d4770a5 
…tor, more scorerSupplier() fixes
Changed rewrite method signature, added DV skip to FieldInfo construc…
705fe9b 
…tor, more scorerSupplier() fixes
More fixes
8b24db8
Removing deprecated method getTermVectors(int docID)
7ec4b98
Removed TopScoreDocsCollector.create() and replaced with manager's ne…
5dcff09 
…wCollector()
Deal with removal of TopFieldCollector.create()
d94b22f
@noblepaul
Removed dependencies on deprecated TimeLimitingCollector
5c9dbf0
@noblepaul
removed deprecated methods
9bb7397
@noblepaul
Fixed deprecated methods
7f2a77b
@noblepaul
Fixed syntax errors
6224d6a
@noblepaul
Fixed syntax errors
18ec6ea
Test compilation fixes
4c141a6
Adding our own scorer supplier
f490667
@noblepaul
bulk scorer modified
f5df6c7
@noblepaul
bulk scorer modified
e1fe99f
Don't close a stream during request parsing
bcd4815
Fixing scorer issues with range queries, thereby passing ConvertedLeg…
dfead62 
…acyTest
Fixing SortedSetDocValues.NO_MORE_ORDS removal issue, fixed SolrIndex…
a6ede24 
…ConfigTest
More improper ordinals handling
20eb534
More ords handling fixed, passing TestJsonFacets now
266dae8
@noblepaul
Use match all docs for null filter
c723c4d
@cpoerschke
retain only KnnVectorField-is-deprecated changes
153ad2f
@cpoerschke
removed TBD comment and ran gradlew tidy
078a9b7
@cpoerschke
Merge remote-tracking branch 'github_apache/main' into KnnVectorField…
b2a3d63 
…-is-deprecated
@cpoerschke cpoerschke marked this pull request as ready for review January 24, 2025 17:04
HoustonPutman
HoustonPutman approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small documentation comment

alessandrobenedetti
alessandrobenedetti approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@alessandrobenedetti alessandrobenedetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's overall ok, just thinking if it's worth expanding the references we are adding here in regards to KnnFloatVectorField with also KnnByteVectorField, aside from that, it's ok to go!

@cpoerschke cpoerschke merged commit cc9a0f8 into apache:main Feb 3, 2025
3 checks passed
@cpoerschke cpoerschke deleted the KnnVectorField-is-deprecated branch February 3, 2025 14:57
asfgit pushed a commit that referenced this pull request Feb 3, 2025
@cpoerschke
remove deprecated KnnVectorField use (#3121)
f8e4084 
Co-authored-by: Ishan Chattopadhyaya <[email protected]>
Co-authored-by: noblepaul <[email protected]>
(cherry picked from commit cc9a0f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HoustonPutman HoustonPutman HoustonPutman approved these changes

@alessandrobenedetti alessandrobenedetti alessandrobenedetti approved these changes

@epugh epugh Awaiting requested review from epugh

@joel-bernstein joel-bernstein Awaiting requested review from joel-bernstein

@noblepaul noblepaul Awaiting requested review from noblepaul

@chatman chatman Awaiting requested review from chatman

Assignees
No one assigned
Labels
cat:index cat:schema tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpoerschke @alessandrobenedetti @HoustonPutman @noblepaul