Skip to content

SOLR-17614: cross-dc deletes can skip an HTTP hop #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Jan 8, 2025

https://issues.apache.org/jira/browse/SOLR-17614

Note: I ran the module's tests and they passed. But I have no experience with this module (or intention to use it) whatsoever. I'm just scratching an itch to remove a pointless HTTP connection and to use the super-cool EmbeddedSolrServer.

@github-actions github-actions bot added the dependencies Dependency upgrades label Jan 8, 2025
@dsmiley dsmiley requested a review from markrmiller January 8, 2025 22:03
@dsmiley
Copy link
Contributor Author

dsmiley commented Feb 6, 2025

Needs a CHANGES.txt; perhaps in Optimizations. "Cross-DC delete-by-query optimized to fetch deleted documents with one less HTTP hop per batch of IDs". I plan to merge it this weekend after adding that.

Copy link

github-actions bot commented Apr 8, 2025

This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Apr 8, 2025
@HoustonPutman
Copy link
Contributor

Is there an issue that this is just querying a core instead of a collection after this change?

@dsmiley
Copy link
Contributor Author

dsmiley commented Apr 8, 2025

Not that I know of.

But, I confess IMO Solr should know what is being addressed and treat that as the scope but Solr doesn't care -- in SolrCloud mode, the whole collection (the core is assigned to) is the scope, unless the magic param distrib=false is passed (for queries). Due to the spectre of back-compat... probably our best path forward is to look to the upcoming V2 API as the opportunity to rethink this.

@github-actions github-actions bot removed the stale PR not updated in 60 days label Apr 9, 2025
Copy link

github-actions bot commented Jun 8, 2025

This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency upgrades stale PR not updated in 60 days tool:build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants