-
Notifications
You must be signed in to change notification settings - Fork 737
SOLR-17614: cross-dc deletes can skip an HTTP hop #2963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Needs a CHANGES.txt; perhaps in Optimizations. "Cross-DC delete-by-query optimized to fetch deleted documents with one less HTTP hop per batch of IDs". I plan to merge it this weekend after adding that. |
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
Is there an issue that this is just querying a core instead of a collection after this change? |
Not that I know of. But, I confess IMO Solr should know what is being addressed and treat that as the scope but Solr doesn't care -- in SolrCloud mode, the whole collection (the core is assigned to) is the scope, unless the magic param |
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
https://issues.apache.org/jira/browse/SOLR-17614
Note: I ran the module's tests and they passed. But I have no experience with this module (or intention to use it) whatsoever. I'm just scratching an itch to remove a pointless HTTP connection and to use the super-cool EmbeddedSolrServer.