Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK #2438

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Commits on May 2, 2024

  1. In-memory synthetic SolrCore for QA node (#181)

    * Experimental QA core as proxy in memory
    
    * Experimental QA core as proxy in memory
    
    * Experimental QA core as proxy in memory
    
    * ./gradlew tidy
    
    * Comment out portion that checks for synthetic collection/core existence
    
    * Fixes watches and test cases
    
    * Refactoring to avoid modifying existing method modifiers
    
    * Cleanup
    
    * Some refactoring to minimize changes to SolrCore
    
    * javadoc
    
    * ./gradlew tidy
    
    * code cleanup
    
    * code cleanup
    
    * Fix resource loader issue if configSetName is null
    
    * ./gradlew tidy
    
    * Fixed issue with incorrect collection name in context
    Ensure only one synthetic core created per config set
    
    * ./gradlew tidy
    
    * Correctly use <config set>_core as synthetic core name for clarity
    Should open the registered core on first synthetic core creation since it is a getCore op
    
    * ./gradlew tidy
    
    * Fixed issue with incorrect collection name in context
    patsonluk committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3899231 View commit details
    Browse the repository at this point in the history
  2. Solve merge issue

    patsonluk committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3667958 View commit details
    Browse the repository at this point in the history
  3. ./gradlew tidy

    patsonluk committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c28cc87 View commit details
    Browse the repository at this point in the history
  4. Added License

    ./gradlew tidy
    patsonluk committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9511546 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    08eebe5 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Refactoring after code review

    Do not modify ConfigSetService, instead introduce SyntheticCoreDescriptor which ZkConfigSetService provides special handling
    
    Improved test case in TestCoordinatorRole#testSimple
    patsonluk committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    22fd7dc View commit details
    Browse the repository at this point in the history
  2. Code review changes

    patsonluk committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8e0240d View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'apache-main' into patsonluk/SOLR-17269/synthetic-solr-core

    # Conflicts:
    #	solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java
    patsonluk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7be2234 View commit details
    Browse the repository at this point in the history
  2. Simplify the ZkConfigSetService#setConfigMetadata, remove the auto cr…

    …eate collectiom state part, which no longer works anyway
    patsonluk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    06273ac View commit details
    Browse the repository at this point in the history
  3. ./gradlew tidy

    patsonluk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7d41702 View commit details
    Browse the repository at this point in the history
  4. Improved comment

    patsonluk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    dbfcbaa View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Fixes after code review

    patsonluk committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ac662a3 View commit details
    Browse the repository at this point in the history