Fix 'setup-zk' bash syntax error

[gerlowskija]

Mismatched brackets were causing the 'grep' portion of the conditional to report an error when triggered.

Fixes #759

[HoustonPutman]

Can we test this? I ask because your testing for the other ticket didn't see an error here...

[gerlowskija]

I think our existing testing (see tests/e2e/solrcloud_security_json_test.go) is sufficient here. It never caught the #759 error, because it's not actually an error ("just" some noise in the logs)!

grep -q does print a message to stderr, but it doesn't impact the return status of the grep call, which returns zero/non-zero based on whether it finds a match in /tmp/current_security.json. grep doesn't care that you also asked it to search other files (i.e. ]) that don't exist. So despite the syntax error, the overall conditional still operated as we wanted it to.

We could add an additional test case to solrcloud_security_json_test.go, to cover the case of a security.json file whose contents are {}, but IMO that edgecase is rare enough that it's not worth bloating the runtime of our e2e tests.

If anyone disagrees though, lmk and I'll add it in. Otherwise, I'll probably target early next week to merge this.

[madrob]

I would consider pulling the entire scriptlets into separate files and then you can run spellcheck on those?

[gerlowskija]

"Spellcheck" or "ShellCheck"?

Assuming you mean "ShellCheck", but I'm not too familiar with it. Seems like a good thing to have analysis on generally - our unit tests validate that the container "command" looks the way we expect, but nothing ever really ensures that it's even valid bash 😦

Thanks for the pointer; will take a look and file a follow-on ticket if it seems promising!

[madrob]

Yes, shellcheck. Auto-correct got me!