[Feature][Engine] Change the name of the rest-api interface for returning job info #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b details was changed from running-job to job-info apache#6812
…b details was changed from running-job to job-info apache#6812
Hisoka-X
added
First-time contributor
3 tasks
…b details was changed from running-job to job-info apache#6812
…b details was changed from running-job to job-info apache#6812
Hisoka-X
reviewed
May 9, 2024
docs/en/seatunnel-engine/rest-api.md
Outdated
|
|
||
| ------------------------------------------------------------------------------------------ | ||
|
|
||
| ### Return details of a job @Deprecated. |
There was a problem hiding this comment.
Suggested change
| ### Return details of a job @Deprecated. | |
| ### Return details of a job. This API has been deprecated, please use /hazelcast/rest/maps/job-info/:jobId instead |
docs/zh/seatunnel-engine/rest-api.md
Outdated
|
|
||
| ------------------------------------------------------------------------------------------ | ||
|
|
||
| ### 返回作业的详细信息(已弃用)。 |
There was a problem hiding this comment.
Suggested change
| ### 返回作业的详细信息(已弃用)。 | |
| ### 返回作业的详细信息。此API已经启用，请使用/hazelcast/rest/maps/job-info/:jobId替代 |
|
|
||
| public class RestHttpGetCommandProcessor extends HttpCommandProcessor<HttpGetCommand> { | ||
| public static class RestHttpGetCommandProcessor extends HttpCommandProcessor<HttpGetCommand> { |
There was a problem hiding this comment.
mvn spotless:apply，missed check . modified
| @@ -300,6 +296,54 @@ private void handleJobInfoById(HttpGetCommand command, String uri) { | |||
| } | |||
| } | |||
|
|
|||
| private void handleJobInfoByJobId(HttpGetCommand command, String uri) { | |||
There was a problem hiding this comment.
I think we can reuse handleJobInfoById method, not create new one.
…b details was changed from running-job to job-info apache#6812
…b details was changed from running-job to job-info apache#6812
Hisoka-X
reviewed
May 9, 2024
Comment on lines
+256
to
+269
| IMap<Object, Object> jobInfoMap = | ||
| this.textCommandService | ||
| .getNode() | ||
| .getNodeEngine() | ||
| .getHazelcastInstance() | ||
| .getMap(Constant.IMAP_RUNNING_JOB_INFO); | ||
| JobInfo jobInfo = (JobInfo) jobInfoMap.get(Long.valueOf(jobId)); | ||
| IMap<Object, Object> finishedJobStateMap = | ||
| this.textCommandService | ||
| .getNode() | ||
| .getNodeEngine() | ||
| .getHazelcastInstance() | ||
| .getMap(Constant.IMAP_FINISHED_JOB_STATE); | ||
| JobState finishedJobState = (JobState) finishedJobStateMap.get(Long.valueOf(jobId)); |
There was a problem hiding this comment.
Any reason for change this? Seem like no difference between before.
There was a problem hiding this comment.
In openEuler system, call /hazelcast/rest/maps/running-job/ returned to {} ，remote debug finds that the JobState object is not returned correctly. After the code is modified, the JobState object can be returned correctly
There was a problem hiding this comment.
Feeling a little strange. cc @hailin0 @EricJoy2048
Hisoka-X
changed the title
Hisoka-X
reviewed
May 9, 2024
Hisoka-X
approved these changes
May 9, 2024
EricJoy2048
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…b details was changed from running-job to job-info #6812
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.