Skip to content

[Improve] ElasticSearch service address configuration supports the following two formats #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhangshenghang
Copy link
Member

@zhangshenghang zhangshenghang commented Mar 21, 2025

Purpose of this pull request

ElasticSearch service address configuration supports the following two formats:

  1. Single node mode: a single string, such as "127.0.0.1:9200"
  2. Cluster mode: JSON array string, such as ["127.0.0.1:9200", "127.0.0.2:9200"]
image image

Check list

@zhangshenghang zhangshenghang requested a review from Hisoka-X April 10, 2025 12:17
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure if this special handling is necessary, because there are still a lot of array parameters, do we have to adapt to all of them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants