RANGER-5148: Fix redundant role cache modifications triggered by role ... #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version changes in scenarios with many plugin clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… version changes in scenarios with many plugin clients
What changes were proposed in this pull request?
The purpose of this change is to address the issue of redundant role cache modifications in concurrent scenarios, as described in [ranger - 5148]. After acquiring the lock, a check is performed to determine whether the role version number in the cache is already greater than or equal to the version number retrieved from the database. If this condition evaluates to true, the cached data can be directly returned.
How was this patch tested?
I manually tested this patch. Through means like debugging and with the help of tools such as JMeter, I simulated concurrent request scenarios. In these scenarios, threads competing for the lock will either directly access the cache or print the contents of the patch in the debug logs.