RANGER-5147: Modernize some Python scripts now that Python 3 is a requirement #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need to keep compatibility with Python 2.
We no longer need to keep compatibility with Python 2.
This method was added in Python 3.2 as a replacement for `readfp`, which was removed in a later version of Python. Ranger requires at least Python 3.8, so it's safe to use the replacement.
We no longer need to keep compatibility with Python 2.
We no longer need to keep compatibility with Python 2.
The backtick does not have to be escaped in string constants.
The Python interpreter, when it sees e.g. "%s\jisql", issues a warning that `\j` is not a valid escape, then converts it to `\\j` anyway, so in the end this ends up as a valid Windows path after all. But this *is* technically a syntax error and I heard over the grapevine that it will turn into a hard error some time in the future. Also, some users really don't like warnings in their logs.
mneethiraj
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Now that Python 3 is a requirement, we can remove some compatibility with Python 2, replace obsolete function calls and fix escape sequences that Python 3 treats as invalid.
This is not a comprehensive review of all Python scripts! Just the things that we noticed while having to adjust to a version of Python that's even newer than the 3.8 given as the minimum required version.
How was this patch tested?
Some of those changes are running in production on our deployments.