Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][fn] Set default tenant and namespace for ListFunctions cmd #23881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #23880

Main Issue: #xyz

PIP: #xyz

Motivation

The list sources and sinks command will use default tenant and namespace when not specified, the list functions cmd should have the same bahaviour

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change added tests and can be verified as follows:

    • Added unit test for list functions to use default tenant and namespace

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
    • when list functions using pulsar-admin without tenant and namespace, no error will be thrown, but the default tenant public and namespace default will be used
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#38

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] pulsar-admin functions list without specifying tenant and namespace return a NPE error
1 participant