Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Remove ConcurrentOpenHashMap and ConcurrentOpenHashSet #23329

Conversation

BewareMyPower
Copy link
Contributor

Main Issue: #23215

Motivation

This is the last PR that removes all left ConcurrentOpenHashXxx references from the code base. Ignored the removals of these two classes and tests, the changes are only +40-90.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: BewareMyPower#37

@BewareMyPower
Copy link
Contributor Author

Though it's ready to merge now (all required tests passed). Let's wait for the flaky test result and see if there are some regressions.

@BewareMyPower BewareMyPower merged commit 9012422 into apache:master Sep 23, 2024
59 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.58%. Comparing base (bbc6224) to head (5f4bfa4).
Report is 595 commits behind head on master.

Files with missing lines Patch % Lines
...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23329      +/-   ##
============================================
+ Coverage     73.57%   74.58%   +1.01%     
- Complexity    32624    34443    +1819     
============================================
  Files          1877     1934      +57     
  Lines        139502   144980    +5478     
  Branches      15299    15838     +539     
============================================
+ Hits         102638   108136    +5498     
+ Misses        28908    28560     -348     
- Partials       7956     8284     +328     
Flag Coverage Δ
inttests 27.49% <82.35%> (+2.91%) ⬆️
systests 24.55% <64.70%> (+0.22%) ⬆️
unittests 73.95% <94.11%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ache/pulsar/broker/namespace/NamespaceService.java 73.37% <100.00%> (+1.14%) ⬆️
...roker/service/persistent/MessageDeduplication.java 80.00% <100.00%> (-0.92%) ⬇️
...pulsar/broker/stats/ClusterReplicationMetrics.java 100.00% <100.00%> (ø)
...va/org/apache/pulsar/client/impl/ConsumerBase.java 74.82% <100.00%> (+0.70%) ⬆️
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 79.95% <100.00%> (+2.37%) ⬆️
...he/pulsar/client/impl/PartitionedProducerImpl.java 81.11% <100.00%> (+0.34%) ⬆️
...va/org/apache/pulsar/client/impl/ProducerBase.java 82.35% <100.00%> (+3.50%) ⬆️
.../org/apache/pulsar/websocket/WebSocketService.java 80.14% <100.00%> (-1.11%) ⬇️
.../org/apache/pulsar/websocket/stats/ProxyStats.java 83.78% <100.00%> (-0.43%) ⬇️
...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java 59.04% <0.00%> (-22.34%) ⬇️

... and 590 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants