Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker] Fix out-of-order issues with ConsistentHashingStickyKeyConsumerSelector #23327

Merged
merged 21 commits into from
Oct 2, 2024
Merged

[fix][broker] Fix out-of-order issues with ConsistentHashingStickyKeyConsumerSelector #23327

merged 21 commits into from
Oct 2, 2024

Commits on Oct 1, 2024

  1. [fix][broker] Fix ordering issue with ConsistentHashingStickyKeyConsu… 

    …merSelector
    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e8de731 View commit details
    Browse the repository at this point in the history

  2. Improve test

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c0f101d View commit details
    Browse the repository at this point in the history

  3. Use insertion sorting for more stability

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d9544dd View commit details
    Browse the repository at this point in the history

  4. Update test to match the impl

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8313f07 View commit details
    Browse the repository at this point in the history

  5. Improve

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9c8365c View commit details
    Browse the repository at this point in the history

  6. Add test that checks hash ranges to get a visual clue of the problem

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ce0e0c5 View commit details
    Browse the repository at this point in the history

  7. Improve tests

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d39a9f2 View commit details
    Browse the repository at this point in the history

  8. Additional check

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1c5967c View commit details
    Browse the repository at this point in the history

  9. Improve test

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    366fb88 View commit details
    Browse the repository at this point in the history

  10. Fix test

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1b6c6cc View commit details
    Browse the repository at this point in the history

  11. Polish

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    01d77a2 View commit details
    Browse the repository at this point in the history

  12. Sort if selected consumer was removed

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    54d989f View commit details
    Browse the repository at this point in the history

  13. Fix NPE when non-existing consumers were removed

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    079fb85 View commit details
    Browse the repository at this point in the history

  14. Remove ordering by name and priority level

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8ac47e4 View commit details
    Browse the repository at this point in the history

  15. Use a weights based solution where the size of the range have an impact

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    346b344 View commit details
    Browse the repository at this point in the history

  16. Use approach where each duplicate consumer name will have different n… 

    …ame index which is sufficiently consistent
    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    586d745 View commit details
    Browse the repository at this point in the history

  17. Add test to validate that range didn't change

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    45d56fd View commit details
    Browse the repository at this point in the history

  18. Increase number of points to distribute more evenly

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c2f1c59 View commit details
    Browse the repository at this point in the history

  19. Move to separate files

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    83e2479 View commit details
    Browse the repository at this point in the history

  20. Refactor

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1a11b4e View commit details
    Browse the repository at this point in the history

  21. Add testConsumersReconnect test

    @lhotari
    lhotari committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    22b95a7 View commit details
    Browse the repository at this point in the history