-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Replace ConcurrentOpenHashMap with ConcurrentHashMap in Topic classes #23322
Merged
BewareMyPower
merged 8 commits into
apache:master
from
BewareMyPower:bewaremypower/concurrent-openhashmap-topic
Sep 21, 2024
Merged
[improve][broker] Replace ConcurrentOpenHashMap with ConcurrentHashMap in Topic classes #23322
BewareMyPower
merged 8 commits into
apache:master
from
BewareMyPower:bewaremypower/concurrent-openhashmap-topic
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p in Topic classes
BewareMyPower
added
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
area/broker
labels
Sep 19, 2024
BewareMyPower
requested review from
lhotari,
eolivelli,
nodece,
RobertIndie,
Demogorgon314,
poorbarcode and
thetumbled
September 19, 2024 12:28
6 tasks
RobertIndie
approved these changes
Sep 20, 2024
Demogorgon314
approved these changes
Sep 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23322 +/- ##
============================================
+ Coverage 73.57% 74.63% +1.06%
- Complexity 32624 33891 +1267
============================================
Files 1877 1936 +59
Lines 139502 145546 +6044
Branches 15299 15928 +629
============================================
+ Hits 102638 108632 +5994
+ Misses 28908 28608 -300
- Partials 7956 8306 +350
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: #23215
Modifications
Apply the replacements for classes that implement
org.apache.pulsar.broker.service.Topic
interface.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: BewareMyPower#36