[improve][broker] Should notify bundle ownership listener onLoad event when ServiceUnitState start (ExtensibleLoadManagerImpl only) #23152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
reviewed
Aug 12, 2024
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
heesung-sn
previously approved these changes
Aug 12, 2024
lhotari
reviewed
Aug 12, 2024
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23152 +/- ##
============================================
+ Coverage 73.57% 74.57% +0.99%
- Complexity 32624 33670 +1046
============================================
Files 1877 1921 +44
Lines 139502 144494 +4992
Branches 15299 15810 +511
============================================
+ Hits 102638 107750 +5112
+ Misses 28908 28502 -406
- Partials 7956 8242 +286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 7dabfd4.
heesung-sn
approved these changes
Aug 12, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 22, 2024
…t when ServiceUnitState start (ExtensibleLoadManagerImpl only) (apache#23152) (cherry picked from commit 3053b64) (cherry picked from commit 9a090f7)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 23, 2024
…t when ServiceUnitState start (ExtensibleLoadManagerImpl only) (apache#23152) (cherry picked from commit 3053b64) (cherry picked from commit 9a090f7)
|
This test is very flaky. Would it be possible to fix it or disable it until it works? Reported #23240 for this |
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…t when ServiceUnitState start (ExtensibleLoadManagerImpl only) (apache#23152)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
ExtensibleLoadManagerImplbehavior is not the same as the old LB, the old LB’s ownership will be empty when the broker starts.When
ExtensibleLoadManagerImplstarts, it may have some owners will be loaded into table view, and those ownerships will not trigger the bundle ownership listener, which may cause some issues, for example, the kop relies on the load event to load the offset topics.Modifications
Notify bundle ownership listener
onLoadevent when ServiceUnitState starts.Documentation
docdoc-requireddoc-not-neededdoc-complete