HDDS-12167. Cannot use sample compose definition with SHA-based image #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sample
docker-compose.yaml
setsOZONE_IMAGE_FLAVOR
to-rocky
, if unset or empty. This makes it cumbersome to use the definition with images identified by commit SHA. Straightforward way results in error:Possible workaround: splitting the SHA value between
OZONE_IMAGE_VERSION
andOZONE_IMAGE_FLAVOR
as:Since we plan to publish images also without
-rocky
suffix anyway, and all existing images are available both with and without (although those without it may be outdated, except 1.4.1), I think it's safe to make flavor optional (use empty value by default).https://issues.apache.org/jira/browse/HDDS-12167
How was this patch tested?