-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/xtensa: fix definition for _int32_t
and _uint32_t
#16022
base: master
Are you sure you want to change the base?
arch/xtensa: fix definition for _int32_t
and _uint32_t
#16022
Conversation
Modify types.h and inttypes.h to use the correct _int32_t and _uint32_t types. Type is now defined according to recent compiler versions. Signed-off-by: Filipe Cavalcanti <[email protected]>
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements. The summary clearly explains the problem, the solution, and the affected code. The impact section addresses all relevant areas, noting the specific hardware affected (Xtensa) and the improved compatibility. While ideally more detailed local testing logs would be included, the explanation regarding Espressif's internal CI and the comprehensive list of tested defconfigs provide reasonable assurance of testing. The connection to issue #15755 adds valuable context. |
|
@yamt seems we have an issue on |
Fix format specifier macros after compiler type changes. Signed-off-by: Filipe Cavalcanti <[email protected]>
Fix format specifier macros after compiler type changes. Signed-off-by: Filipe Cavalcanti <[email protected]> Fix boards with PRI
494b020
to
20adec7
Compare
Applied the changes recommended. Let's please hold this PR while we fix the |
Summary
Modify
types.h
andinttypes.h
to use the correct_int32_t
and_uint32_t
types, on Xtensa arch.This PR solves an issue first mentioned in #15755.
Type is now defined according to recent compiler versions.
On xtensa-esp32-gcc version 8.4.0 we have:
While version 12.2.0 has:
Due to this type modification, many logging calls had to be fixed with the proper format specifiers: %u, %lu, %ld, etc across arch and board files.
Impact
Testing
Most tests done on Espressif's internal CI. Each build that failed had the error fixed, resulting in the commits of this PR.
Since errors are all logging related, the build system should catch everything.
Tested build on all defconfigs for: