arch/risc-v/mpfs ethernet improvements #15979
Merged
+77
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use LPWORK by default if CONFIG_MPFS_ETHMAC_HPWORK is not defined - Always use LPWORK for timeouts; this makes very lengthy operations such as re-initializing PHY. Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
…roken PHYs If the interface is UP, and no packets are received in 30s, re-initialize the interface by calling the already implemented mpfs_txtimeout_expiry. This is a workaround for a bug where IF might be UP and working but packets can only be transmitted. Receive side just doesn't work at all. The bug manifests at least in older LAN8742A (rev A and B), for which also a silicon errata exists. The original issue can be re-produced easily by disconnecting and reconnecting the ethernet cable while the IF is up. Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
…UG_NET - Fix compilation failure "error: 'mpfs_phydump' defined but not used [-Werror=unused-function]" - Add debug dump of phy registers. Signed-off-by: Jukka Laitinen <jukkax@ssrc.tii.ae>
mpfs_phyinit() was called twice during ifup(). Signed-off-by: Jani Paalijarvi <jani.paalijarvi@unikie.com>
github-actions
bot
added
Arch: risc-v
|
[Experimental Bot, please feedback here] Yes, this PR appears to meet the basic NuttX requirements, but could be improved. While it provides a summary of the changes and testing information, it lacks detail in the Impact section. Specifically, it needs to address most of the "NO/YES" questions with more than a single sentence. For example, even though the impact is stated as "only MPFS ethernet," the PR should explicitly state NO for impacts like user changes, build process changes, documentation updates, security implications, etc. If any of these are YES, then a detailed explanation is required. The testing section also needs to include actual logs, not just a description of the test environment. |
pussuw
approved these changes
Mar 12, 2025
lupyuen
approved these changes
Mar 12, 2025
acassis
approved these changes
Mar 12, 2025
jerpelea
changed the title
jlaitine
force-pushed
the
mpfs_ethernet_improvements
branch
from
64d2953 to
0c06e37
Compare
|
I believe I have addressed all the review comments, is this good to go in? |
Verify that GMAC RX/TX buffers are 64 byte aligned Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
jlaitine
force-pushed
the
mpfs_ethernet_improvements
branch
from
0c06e37 to
7985c55
Compare
xiaoxiang781216
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the mpfs_ethernet driver by picking the following corrections from TII/SSRC branches:
Impact
Impacts only MPFS ethernet, improves reliability.
user changes: NO
build process changes: NO
documentation updates: NO
security implications: NO
Testing
Build Host: Ubuntu 22.04
Target: icicle:hwtest & 3 custom HW designs.