Fix MavenProject#getPlugin(String) performances #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2025
Closed
|
RAO is down for HW migration https://status.apache.org/ |
…jects The Plugin objects returned by MavenProject.getPlugin() were disconnected from the project model because they were created with new Plugin(plugin) without a parent BaseObject. This fix passes getBuild() as the parent to the Plugin constructor, ensuring that modifications to Plugin objects (setVersion, setConfiguration, etc.) persist in the project model. The change maintains the performance improvement from the original PR while fixing the connection issue, similar to how ConnectedResource works for Resource objects.
cstamas
reviewed
Jul 2, 2025
impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Jul 3, 2025
impl/maven-core/src/test/java/org/apache/maven/project/PluginConnectionSimpleTest.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
Jul 4, 2025
| @@ -1240,7 +1240,9 @@ public String getDefaultGoal() { | |||
| } | |||
|
|
|||
| public Plugin getPlugin(String pluginKey) { | |||
| return getBuild().getPluginsAsMap().get(pluginKey); | |||
| org.apache.maven.api.model.Plugin plugin = | |||
There was a problem hiding this comment.
why do we have both org.apache.maven.model.Plugin and org.apache.maven.api.model.Plugin? I'm not sure, but this might be a symptom of too many packages, over-abstraction, or both. Do we need multiple plugin types?
There was a problem hiding this comment.
We're translating from the Maven 3 api to the Maven 4 api here. org.apache.maven.model.Plugin is the Maven 3 api, with mutable objects. org.apache.maven.api.model.Plugin is the (now underlying) Maven 4 api with immutable objects.
This is somewhat temporary, the plan is to get away with the Maven 3 api in Maven 5. But we need it to support Maven 3 plugins in Maven 4 and not break everything.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 4, 2025
* Fix MavenProject#getPlugin(String) performances * Fix Plugin connection: ensure getPlugin() returns connected Plugin objects The Plugin objects returned by MavenProject.getPlugin() were disconnected from the project model because they were created with new Plugin(plugin) without a parent BaseObject. This fix passes getBuild() as the parent to the Plugin constructor, ensuring that modifications to Plugin objects (setVersion, setConfiguration, etc.) persist in the project model. The change maintains the performance improvement from the original PR while fixing the connection issue, similar to how ConnectedResource works for Resource objects. * Do not use var keyword * Add pointer (cherry picked from commit 0b29d8f)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
that referenced
this pull request
Jul 4, 2025
* Fix MavenProject#getPlugin(String) performances * Fix Plugin connection: ensure getPlugin() returns connected Plugin objects The Plugin objects returned by MavenProject.getPlugin() were disconnected from the project model because they were created with new Plugin(plugin) without a parent BaseObject. This fix passes getBuild() as the parent to the Plugin constructor, ensuring that modifications to Plugin objects (setVersion, setConfiguration, etc.) persist in the project model. The change maintains the performance improvement from the original PR while fixing the connection issue, similar to how ConnectedResource works for Resource objects. * Do not use var keyword * Add pointer (cherry picked from commit 0b29d8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.