[DRAFT] [MASSEMBLY-925] Detailed error message on assembly failure

src/main/java/org/apache/maven/plugins/assembly/filter/ComponentsXmlArchiverFileFilter.java

@@ -137,9 +137,16 @@ public void finalizeArchiveCreation( final Archiver archiver )
         // runArchiveFinalizers() is called before regular resources are added...
         // which is done because the manifest needs to be added first, and the
         // manifest-creation component is a finalizer in the assembly plugin...
-        for ( final ResourceIterator it = archiver.getResources(); it.hasNext(); )
+        try
+        {
+            for ( final ResourceIterator it = archiver.getResources(); it.hasNext(); )
+            {
+                it.next();
+            }
+        }
+        catch ( ArchiverException e )
         {
-            it.next();
+            throw new ArchiverException( "Failed on finalizing archive creation " + e.getMessage() );
         }
 
         try

src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java

@@ -501,9 +501,10 @@ public void execute() throws MojoExecutionException, MojoFailureException
         boolean warnedAboutMainProjectArtifact = false;
         for ( final Assembly assembly : assemblies )
         {
+            String fullName = "";
             try
             {
-                final String fullName = AssemblyFormatUtils.getDistributionName( assembly, this );
+                fullName = AssemblyFormatUtils.getDistributionName( assembly, this );
 
                 List<String> effectiveFormats = formats;
                 if ( effectiveFormats == null || effectiveFormats.size() == 0 )
@@ -515,12 +516,12 @@ public void execute() throws MojoExecutionException, MojoFailureException
                     throw new MojoFailureException(
                             "No formats specified in the execution parameters or the assembly descriptor." );
                 }
-
+                System.out.println( "519" );
                 for ( final String format : effectiveFormats )
                 {
                     final File destFile = assemblyArchiver.createArchive( assembly, fullName, format, this,
                             isRecompressZippedFiles(), getMergeManifestMode(), outputDate );
-
+                    System.out.println( "524" );
                     final MavenProject project = getProject();
                     final String type = project.getArtifact().getType();
 
@@ -574,7 +575,8 @@ else if ( attach )
             }
             catch ( final ArchiveCreationException | AssemblyFormattingException e )
             {
-                throw new MojoExecutionException( "Failed to create assembly: " + e.getMessage(), e );
+                throw new MojoExecutionException( "Failed to create assembly: " + e.getMessage()
+                        + " Full name is: " +  fullName, e );
             }
             catch ( final InvalidAssemblerConfigurationException e )
             {