[MASSEMBLY-775] remove false OS-specific warnings/errors

[petteyg]

According to various references, "/" being an invalid directory separator on Windows was never true. Besides, the OS on which an assembly is generated and the OS on which it is consumed may differ, so blind checks of the build-time system are nonsensem. Just remove the whole thing.

[Tunaki]

These checks are ran when generating the assembly during the build, not when consuming it.

They aren't about / being the directory separator, but having a path starting with / on a Windows system. This is most likely a problem because it is unlikely this is what the user wanted. Likewise, if you're making an assembly on Linux referencing a path starting with, e.g., C:, there is probably a configuration issue.

Is there a specific case that you encountered which prompted for this change?

[petteyg]

Copying from the JIRA ticket since it doesn't sync both ways...

It's not checking "a path starting with / on a Windows system". Every one of those checks is for the destination path. It's checking a path starting with / as the target path in the assembled archive, which is utter nonsense. The zip/tar/whatever file isn't ever going to have "Windows" paths with drive letters in it (and if you supplied one as a target path, I suspect the archiver code is going to barf an exception at you because that's invalid in every archive format I know of - no need to duplicate a check in the assembly plugin). / is the appropriate way to specify the root directory of the target archive.

[spiritualops]

How are zip archives deployed to Windows servers with this plugin? Just curious.

[spiritualops]

One last thing, don't forget to bump the patch version in the pom. ;)

[elharo]

Can this be finished up?

[rfscholte]

Superceded by #14