add ability to set hostname in TelnetAppender #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michieldwitte
force-pushed
the
add_hostname
branch
from
77d99fe to
637bc70
Compare
swebb2066
reviewed
May 9, 2025
| /** | ||
| The <b>Hostname</b> on which to accept connections. | ||
| */ | ||
| LogString getHostname() const; |
There was a problem hiding this comment.
Would 'NodeName' be bettter than 'HostName' given it identifies the local machine interface to be used?
I believe that would correspond better with the underlying terminology and distinguish it from a url used to identify a remote server.
There was a problem hiding this comment.
The apr_sockaddr_info_get argument name is "hostname"
https://apr.apache.org/docs/apr/1.5/group__apr__network__io.html#gaa2f399ca2b60b35c0abf7630298c6c9f
michieldwitte
force-pushed
the
add_hostname
branch
from
637bc70 to
07e9246
Compare
By default it accepts on any network interface, I've validated it using "127.0.0.1" so it only accepts connections on the loopback interface. |
swebb2066
reviewed
May 10, 2025
michieldwitte
force-pushed
the
add_hostname
branch
from
07e9246 to
4b29833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to set hostname in TelnetAppender