MINOR : Handle error for client telemetry push #19881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbejeck
approved these changes
Jun 2, 2025
|
@k-raina thanks for this contribution. has analogous issue asNoClassDefFoundError is not caught correctly. Could you please fix it as well?
|
Comment on lines
720
to
721
| } catch (Throwable e) { | ||
| log.info("Failed to compress telemetry payload for compression: {}, sending uncompressed data", compressionType); |
There was a problem hiding this comment.
For log.info("Failed to compress telemetry payload for...., should it be in debug mode i.e. silent exception. Or we should still log it in INFO mode so application is aware of? What others think @AndrewJSchofield @bbejeck @chia7712 @k-raina?
There was a problem hiding this comment.
agreed. Using info may caused the log to be flooded with messages. If that is acceptable exception, then using debug mode should be fine.
There was a problem hiding this comment.
Updated to debug logs 3ea7dbb
apoorvmittal10
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update catch to handle compression errors
Before :
After