MINOR: Refactor write timeout in CoordinatorRuntime #15976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
May 16, 2024
|
|
||
| @Override | ||
| public void run() { | ||
| String name = event.toString(); |
There was a problem hiding this comment.
It does not include if (!future.isDone()) { now. Is it ok? I don't have much context :)
There was a problem hiding this comment.
We don't need it anymore because we cancel the timer when the operation is completed. The future is completed at the same time so it is equivalent.
| @Override | ||
| public void run() { | ||
| String name = event.toString(); | ||
| scheduleInternalOperation("OperationTimeout", tp, |
There was a problem hiding this comment.
previous operation name carries more information. Should we keep it? for instance: "OperationTimeout(name=" + name + ", tp=" + tp + ")"
chia7712
approved these changes
May 17, 2024
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
May 24, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a small refactor in the CoordinatorRuntime. It relies on existing tests for correctness.
Committer Checklist (excluded from commit message)