KAFKA-7342: Migrate tests in o.a.k.streams to JUnit 5 (except KafkaStreamsTest) #15942
Conversation
…Test) Migrates tests in org.apache.kafka.streams (excluding sub-packages) to JUnit 5. KafkaStreamsTest is not migrated since it needs some more work due to unnecessary stubbings exceptions.
| @@ -330,8 +327,6 @@ public void shouldNotAllowToAddStateStoreToSink() { | |||
|
|
|||
| private void mockStoreBuilder() { | |||
| when(storeBuilder.name()).thenReturn("store"); | |||
| when(storeBuilder.logConfig()).thenReturn(Collections.emptyMap()); | |||
There was a problem hiding this comment.
I assume Mockito said these are unnecessary?
There was a problem hiding this comment.
Yeah, it is somehow strange. We tried to define Mockito with strict stubs but now with the migration to JUnit 5 it turns out that it was that strict after all. I haven't yet understood why we get unnecessary stubbing exceptions. 🤔
In this specific case, it does not make any difference from a stubbing point of view since the return values are the default return values. So instead of considering lenient, I just removed the stubs.
|
There are some test failures of the following kind I do not yet know whether these have been introduced by the MockitoExtensions in this PR or another PR which has already been merged |
This comes from there: I do not think it is related to this PR, but I will have a closer look. |
cadonna
changed the title
…Test) (apache#15942) Reviewers: Christo Lolov <[email protected]>, Chia-Ping Tsai <[email protected]>
Migrates tests in org.apache.kafka.streams (excluding sub-packages) to JUnit 5.
KafkaStreamsTest is not migrated since it needs some more work due to unnecessary stubbings exceptions.
Committer Checklist (excluded from commit message)