[LIVY-1001][RSC] ContextLauncher has a potential NullPointerException… #447
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception during the livy session creating process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve potential NPE issues during session creation.
What changes were proposed in this pull request?
Logically speaking, the non-zero judgment of refCount is not rigorous, which will result in the server attribute not being created.
https://issues.apache.org/jira/browse/LIVY-1001
How was this patch tested?
I manually constructed the abnormal situation during the creation of RpcServer. Specifically, launcher.port.range="10000~10001" and ports 10000,10001 are all occupied.