-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#970: Test Scenario Editor: Integrate the @kie-tools/scesim-editor
component with the DMN Marshaller
#2887
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # packages/scesim-editor/src/creation/TestScenarioCreationPanel.tsx # packages/scesim-editor/stories/dev/DevWebApp.stories.tsx # packages/scesim-editor/stories/scesimEditorStoriesWrapper.tsx # repo/graph.json
🥳 🍾 🚀 |
Thank you for the PR @yesamer. This is a huge milestone for the project and I believe for you as a contributor too! It's amazing to see everything coming together in the videos you shared, they look great. I'll dedicate some time to reviewing the code itself, so give me a few days please. @ljmotta Would you be available for helping @yesamer with the screenshots for tests? I know you've been busy with multiple PRs and that we're so close to having the containerized tests PR ready, but if that needs more time we can definitely move this one forward by having someone update the screenshots for @yesamer. Thank you!! |
01
|
02 DMN models in built project |
03 Included models |
04 Nested structures |
I am done with my review. I think I took a look on important features. Not sure what will be the process here. If there will be some code added into this PR, let me know. Otherwise, I can check reported issues in separate PRs. Thank you @yesamer for this great milestone! |
Thank you @jomarko, I'm glad the overall result is not so bad, the first issue you reported is the most critical one, in my opinion. I intend to manage them separately and merge this PR as soon as possible. |
Closes apache/incubator-kie-issues#970
This PR integrates the new Scesim Editor with the DMN Marshaller, making it possible to retrieve required information from an External DMN Model.
To whoever will review and test this PR, please consider some KI have already reported here
In addition, some use cases are still not fully implemented (eg. collections, expressions, nested data objects)
Those will be managed with apache/incubator-kie-issues#1514
Some examples:
Opening an existing Scesim file:
Screen.Recording.2025-02-05.at.15.24.17.mov
Creating a new DMN-based Scesim file with auto-population
Screen.Recording.2025-02-05.at.15.17.19.mov
Creating a new DMN-based Scesim file without auto-population
Screen.Recording.2025-02-05.at.15.19.16.mov
Opening an existing DMN-based Scesim file with the referenced DMN file removed
Screen.Recording.2025-02-05.at.15.27.45.mov
Opening an existing DMN-based Scesim file with the referenced DMN file moved to another location
Screen.Recording.2025-02-05.at.16.43.28.mov
Blocked by #2866. Required to update the tests.