Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#970: Test Scenario Editor: Integrate the @kie-tools/scesim-editor component with the DMN Marshaller #2887

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented Jan 30, 2025

Closes apache/incubator-kie-issues#970

This PR integrates the new Scesim Editor with the DMN Marshaller, making it possible to retrieve required information from an External DMN Model.

To whoever will review and test this PR, please consider some KI have already reported here

In addition, some use cases are still not fully implemented (eg. collections, expressions, nested data objects)
Those will be managed with apache/incubator-kie-issues#1514

Some examples:

Opening an existing Scesim file:

Screen.Recording.2025-02-05.at.15.24.17.mov

Creating a new DMN-based Scesim file with auto-population

Screen.Recording.2025-02-05.at.15.17.19.mov

Creating a new DMN-based Scesim file without auto-population

Screen.Recording.2025-02-05.at.15.19.16.mov

Opening an existing DMN-based Scesim file with the referenced DMN file removed

Screen.Recording.2025-02-05.at.15.27.45.mov

Opening an existing DMN-based Scesim file with the referenced DMN file moved to another location

Screen.Recording.2025-02-05.at.16.43.28.mov

Blocked by #2866. Required to update the tests.

@yesamer yesamer added pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development area:scesim labels Jan 30, 2025
@yesamer yesamer requested a review from tiagobento as a code owner January 30, 2025 16:19
@jomarko
Copy link
Contributor

jomarko commented Jan 31, 2025

🥳 🍾 🚀

@yesamer yesamer removed pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development labels Feb 5, 2025
@tiagobento
Copy link
Contributor

Thank you for the PR @yesamer. This is a huge milestone for the project and I believe for you as a contributor too! It's amazing to see everything coming together in the videos you shared, they look great.

I'll dedicate some time to reviewing the code itself, so give me a few days please.

@ljmotta Would you be available for helping @yesamer with the screenshots for tests? I know you've been busy with multiple PRs and that we're so close to having the containerized tests PR ready, but if that needs more time we can definitely move this one forward by having someone update the screenshots for @yesamer.

Thank you!!

@jomarko
Copy link
Contributor

jomarko commented Feb 7, 2025

01 mvn clean verify

I was not able to run scesim file apache/incubator-kie-issues#1807

@jomarko
Copy link
Contributor

jomarko commented Feb 7, 2025

02 DMN models in built project

apache/incubator-kie-issues#1808

@jomarko
Copy link
Contributor

jomarko commented Feb 7, 2025

03 Included models

apache/incubator-kie-issues#1809

@jomarko
Copy link
Contributor

jomarko commented Feb 7, 2025

04 Nested structures

apache/incubator-kie-issues#1810

@jomarko
Copy link
Contributor

jomarko commented Feb 7, 2025

I am done with my review. I think I took a look on important features. Not sure what will be the process here. If there will be some code added into this PR, let me know. Otherwise, I can check reported issues in separate PRs.

Thank you @yesamer for this great milestone!

@yesamer
Copy link
Contributor Author

yesamer commented Feb 7, 2025

Thank you @jomarko, I'm glad the overall result is not so bad, the first issue you reported is the most critical one, in my opinion. I intend to manage them separately and merge this PR as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Scenario Editor: Integrate the @kie-tools/scesim-editor component with the DMN Marshaller
4 participants