Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1164: Cut/Copy/Paste Functionality Issues in DRD View: DMN Editor Extension for VSCode (macOS) #2883

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

danielzhe
Copy link
Contributor

@danielzhe danielzhe commented Jan 29, 2025

Closes: apache/incubator-kie-issues#1164
Closes: apache/incubator-kie-issues#1580

Screen.Recording.2025-01-29.at.18.10.23.mov

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danielzhe, will this PR close apache/incubator-kie-issues#1580 as well?

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did brief sanity check in non MacOS environment, sandbox. Seems copy and paste is working for me.

@danielzhe
Copy link
Contributor Author

Thank you @danielzhe, will this PR close apache/incubator-kie-issues#1580 as well?

Yes. I checked and it closes as well, except for the copy-paste for external nodes, which is not an issue since external nodes are unique and can't be duplicated in the same diagram.

@danielzhe
Copy link
Contributor Author

@tiagobento Ready to merge.

@tiagobento tiagobento merged commit 721f4e9 into apache:main Jan 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants