kie-issues#1586: [kn-plugin-workflow] Evaluate if we should install operator via cli #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func NewStatusOperatorCommand() *cobra.Command { |
There was a problem hiding this comment.
I think we can add the default sonataflow-operator-system namespace here:
There was a problem hiding this comment.
good question, to install the operator from operatorhub into some namespace, we should have a namespace and OperatorGroup.
by default (minikube/kind), after we installed olm, where two Operator groups
NAMESPACE NAME AGE
olm olm-operators 7m46s
operators global-operators 7m46s
so to use sonataflow-operator-system as a namespace for sonataflow operator, we should create a name and Operator group before installing the operator inseft.
I am going to implement it in the upcomming issue.
@ricardozanini tdyt ?
|
|
||
| var kubeconfigInfoDisplayed = false | ||
|
|
||
| func (m GoAPI) CanICreate(resourcePath string, namespace string) (bool, error) { |
There was a problem hiding this comment.
Suggested change
| func (m GoAPI) CanICreate(resourcePath string, namespace string) (bool, error) { | |
| func (m GoAPI) IsCreateAllowed(resourcePath string, namespace string) (bool, error) { |
| return false, nil | ||
| } | ||
|
|
||
| func (m GoAPI) CanIDelete(name string, namespace string) error { |
There was a problem hiding this comment.
Suggested change
| func (m GoAPI) CanIDelete(name string, namespace string) error { | |
| func (m GoAPI) IsDeleteAllowed(name string, namespace string) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: apache/incubator-kie-issues#1586
tests will be added after #2800 gets merged. (We need
kindfor e2e tests)