kie-issues#1635: DMN Editor can not reopen List expression #2851
Conversation
There was a problem hiding this comment.
Thank you @Kusuma04-dev for your PR!
IINW, with this change the logic will automatically nest a List Expression inside the created List Expression, as shown in the below image
This is not the expected behavior, we should keep the expression undefined so the user can manually assign the expression to set there.
Based on that, I think you should revert the change and continue your investigation, the bug is in another place, in my opinion.
Hi Yeser,Got it will investigate further. |
Yes Jozef , Updated.Thank you. |
|
@Kusuma04-dev I can confirm the issue is fixed. I can start modeling, define decision as List, close and reopen and continue modeling. However, the test failure seems to be related. Please let us know if you need a help with fixing it. |
Hi @jomarko ,Thanks for the confirmation,I have fixed the tests, can you please check. |
There was a problem hiding this comment.
Thank you @Kusuma04-dev . I think I do not understand properly the fix of the test.
if this is the state after opening boxed list (notice number of rows, not name and data type):
why do we need to click add row 5 times?
await bee.expression.asList().addEntryAtTop();
that would result in list with 6 rows, or am I wrong? while boxed-list-age-group.png has 5 rows
closes apache/incubator-kie-issues#1635 DMN Editor can not reopen List expression
when we have created list expression and go back to home screen and opened dmn again then we are getting below error(not able to reopen the diagram) :
Before fix:
After fix:
